Fix linting errors and bundling failures in JavaScript workflow scripts#5781
Merged
Fix linting errors and bundling failures in JavaScript workflow scripts#5781
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
- Fix template string interpolation bug in maintenance_workflow.go - Add missing expiration_helpers.cjs to embedded scripts in js.go - All unit tests now passing Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
- All workflows recompiled successfully - Bundler now properly includes expiration_helpers.cjs - Scripts are being inlined correctly in workflows Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Format and lint code, fix test issues
Fix linting errors and bundling failures in JavaScript workflow scripts
Dec 7, 2025
This was referenced Dec 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two issues prevented clean builds: unused function linter errors and JavaScript bundling failures causing test failures.
Changes
Fixed template string bug in maintenance workflow generation
${getMaintenanceScript()}in Go string literal to properfmt.Sprintf()with%splaceholderAdded missing embedded script registration
expiration_helpers.cjsinpkg/workflow/js.gowith//go:embeddirective and added toGetJavaScriptSources()mapcreate_issue.cjs,create_discussion.cjs, andcreate_pull_request.cjsfor expiration comment functionalityBefore:
After:
This resolves
TestStagedPreviewInlinedandTestTrackerIDIntegrationtest failures caused by incomplete script bundling.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/user/usr/bin/gh gh api user --jq .login --show-toplevel x_amd64/compile /usr/bin/git wright" --help 64/pkg/tool/linurev-parse x_amd64/compile git rev-�� --show-toplevel x_amd64/compile ache/go/1.25.0/x64/pkg/tool/linujson kflow.test om/actions/cachesecret ortcfg.link ache/go/1.25.0/x--json(http block)/usr/bin/gh gh api user --jq .login celain | head -n 10 x_amd64/asm epo om/actions/uploainfocmp om/actions/uploa-1 ache/node/24.11.xterm-color node pars�� .git /usr/lib/git-core/git /usr/bin/infocmp by/959a494a22431infocmp nly in/node infocmp(http block)/usr/bin/gh gh api user --jq .login entics.git e/git 97011e184ff34d1d123f3a84c06b0176f7c/log.json om/actions/downlgh om/actions/downlsecret /usr/bin/git 7722907/b329/cli--json e=/t�� t0 git 0s tch ache/go/1.25.0/x-namespace bash gh(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.